bolt07: Simplify signature scheme for channel_announcement
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorders the `channel-id` and `bitcoin-signature-x` fields so that the signed part of the message is contiguous. Simplifies the signing logic not to just simple signatures of a contiguous region of the message, no need to sign signatures, they all commit to the same payload. This also removes the chicken and egg problem @pm47 reported in lightning#92. Furthermore it specifies that the signed payload also includes any future appended fields.
|
Adding @Roasbeef as reviewer to have a confirmation that signing the signatures is not needed if all signatures commit to the same message. This may also remove a few cases in which the signature could be reused out of context. |
|
@rustyrussell was proposing that we segregate the witness. In this case we'd compare the |
pm47
approved these changes
Jan 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorders the
channel-idandbitcoin-signature-xfields so that thesigned part of the message is contiguous. Simplifies the signing logic
not to just simple signatures of a contiguous region of the message,
no need to sign signatures, they all commit to the same payload. This
also removes the chicken and egg problem @pm47 reported in #92.
Furthermore it specifies that the signed payload also includes any
future appended fields.