Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProbabilisticScorer.read() - parameters not named correctly #91

Closed
danielnordh opened this issue Jan 23, 2023 · 1 comment
Closed

ProbabilisticScorer.read() - parameters not named correctly #91

danielnordh opened this issue Jan 23, 2023 · 1 comment

Comments

@danielnordh
Copy link

The parameter names are not very helpful here.
I presume they should reflect the expected types as on other platforms.

let scoreResult = ProbabilisticScorer.read(ser: <#T##[UInt8]#>, argA: <#T##Bindings.ProbabilisticScoringParameters#>, argB: <#T##Bindings.NetworkGraph#>, argC: <#T##Bindings.Logger#>)

ser - ?
argA - ProbabilisticScoringParameters
argB - NetworkGraph
argC - Logger

@arik-so
Copy link
Contributor

arik-so commented Jan 24, 2023

Thanks for raising this! The variable names are actually taken automatically from the C bindings, and while we could special-case it here, I think that would be opening up a can of worms. I'll move this issue to the upstream repository and close it here with wontfix if that's all right.

@arik-so arik-so closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants