Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual node +channel prioritization #1239

Closed
TheBlueMatt opened this issue Jan 13, 2022 · 3 comments · Fixed by #1592
Closed

Manual node +channel prioritization #1239

TheBlueMatt opened this issue Jan 13, 2022 · 3 comments · Fixed by #1592
Assignees

Comments

@TheBlueMatt
Copy link
Collaborator

We should have a method in our scorer to manually peanalize (or negative penalty) a given node or channel. Would be cool to have it not decay, too.

@TheBlueMatt TheBlueMatt added this to the 0.1 milestone Jan 13, 2022
@jkczyz jkczyz self-assigned this Jan 13, 2022
@tnull
Copy link
Contributor

tnull commented Jun 28, 2022

Is this still of interest? Do we rather want this to be on a per-node or a per-channel basis? If it's the former I guess it would be a really easy generalization of #1550, i.e., instead of storing banned nodes in a HashSet we'd store manual penalties in a HashMap and banning nodes would simply be adding u64::max_value() penalties.

@jkczyz
Copy link
Contributor

jkczyz commented Jun 28, 2022

Not sure what the context was for this issue. Looks like it predated ProbabilisticScorer or at least was filed while at an earlier stage of the review.

@TheBlueMatt TheBlueMatt removed this from the 0.1 milestone Jul 2, 2022
@TheBlueMatt
Copy link
Collaborator Author

Hmm, yea, I mean I guess #1550 mostly did this, but indeed, I guess it'd be nice to generalize it. Its certainly not critical now that we have a banned nodes list, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants