Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onion message follow-ups #1607

Open
6 of 17 tasks
valentinewallace opened this issue Jul 11, 2022 · 8 comments
Open
6 of 17 tasks

Onion message follow-ups #1607

valentinewallace opened this issue Jul 11, 2022 · 8 comments

Comments

@valentinewallace
Copy link
Contributor

valentinewallace commented Jul 11, 2022

  • Force users to use path_id
  • Enable the addition of dummy blinded hops for increased privacy
  • On creation, pad blinded route hops to be equal length
  • Support 1-hop blinded paths
  • Rate limit based on channel vs non-channel peers
  • Rate limit based on outbound peer buffer limits
  • Refuse to send onion messages to offline peers and drop forwards to offline peers
  • Config option for forwarding over channels-only
  • Custom TLVs, sending-side + handler on receiving side
  • Implement BOLT spec test vectors
  • Consider setting max number of hops before refusing to send
  • Custom get_route for finding an OM path (current get_route has a lot of custom stuff for payments)
  • Flip on OM feature bit (may want to conditionally flip based on whether a user has an OnionMessenger)
  • Refactor onion_utils::construct_onion_packet_with_init_noise to take one Vec instead of two
  • Minor: make onion_utils::decode_next_hop private, see Onion messages v1 #1503 (comment)
  • Add fuzz testing
  • Don't disconnect peers on garbage onion messages (cc Onion messages v1 #1503 (comment))
@TheBlueMatt
Copy link
Collaborator

Support receiving onion messages to phantom nodes.

@valentinewallace
Copy link
Contributor Author

Support receiving onion messages to phantom nodes.

cc #1503 (comment)

@TheBlueMatt
Copy link
Collaborator

Need to have a fuzzer for reading/decoding/forwarding onion messages before we can ship it, I think.

@TheBlueMatt
Copy link
Collaborator

Maybe clean up API a bit, re #1503 (comment)

@valentinewallace
Copy link
Contributor Author

Due to recent spec updates forcing the use of blinded paths, we'll want to support 1-hop blinded paths now too.

@carlaKC
Copy link
Contributor

carlaKC commented May 23, 2023

If nobody is working on it, I'd like to attempt adding the OM test vectors - as requested here.

@TheBlueMatt
Copy link
Collaborator

We should presumably include padding (someone taking over #1771) no?

@valentinewallace
Copy link
Contributor Author

valentinewallace commented Jan 11, 2024

We should presumably include padding (someone taking over #1771) no?

Yeah, that would be good. That's included in the issue already, if that's what you mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants