Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGS Fails When Channel Was Removed #1784

Closed
TheBlueMatt opened this issue Oct 19, 2022 · 0 comments · Fixed by #1833
Closed

RGS Fails When Channel Was Removed #1784

TheBlueMatt opened this issue Oct 19, 2022 · 0 comments · Fixed by #1833
Labels
good first issue Good for newcomers
Milestone

Comments

@TheBlueMatt
Copy link
Collaborator

If we remove a channel, for example because we got a failed payment with an error which told us to, we'll hit the following block, which shouldn't actually be an error, we should simply ignore this and move on. Fixing this is somewhat nontrivial as we still have to read the relevant data, we just have to ignore it, so it will require a bit of code motion.

                    .ok_or(LightningError {
                        err: "Couldn't find channel for update".to_owned(),
                        action: ErrorAction::IgnoreError,
                    })?;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant