Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor Outputs Tracking Issue #2297

Open
7 of 10 tasks
wpaulino opened this issue May 15, 2023 · 5 comments
Open
7 of 10 tasks

Anchor Outputs Tracking Issue #2297

wpaulino opened this issue May 15, 2023 · 5 comments
Assignees

Comments

@wpaulino
Copy link
Contributor

wpaulino commented May 15, 2023

@ariard
Copy link

ariard commented May 16, 2023

There is one more item to check:

  • Ensure the level of fee-bumping reserves is correct for the channel exposure and reasonable worst-historical mempool (you can assign this one to myself)

From a deployment viewpoint, which ones are required to remove the compilation flag #[cfg(anchors)] ? My thinking we can remove the flag for 0.0.116 or 0.0.117, have one or two LDK users integrate anchors and then activate by default anchor channels when we think it’s stable for all the LDK users in 0.0.118 ? It’s not like anchor outputs support is very robust in other implementations so better to be conservative here, I think.

@wpaulino
Copy link
Contributor Author

From a deployment viewpoint, which ones are required to remove the compilation flag #[cfg(anchors)] ?

All of them. Users will still need to opt in manually via:

pub negotiate_anchors_zero_fee_htlc_tx: bool,

@ariard
Copy link

ariard commented May 19, 2023

All of them. Users will still need to opt in manually via:

All good yeah we might let one or two release between the removal of the dedicated compilation flag and turning on by default negotiate_anchors_zero_fee_htlc_tx.

@ariard
Copy link

ariard commented Jun 8, 2023

Some review feedback from #2089:

@ariard
Copy link

ariard commented Jun 30, 2023

And interactions with dust: #2354 (comment)

If we can update the state of anchor output after #2089, #2367 and #2368 that is valuable to know what prioritize next to harden anchor outputs support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

2 participants