-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change max_value_in_flight based on channel being public #2851
Comments
Hello @TheBlueMatt, I'm looking into this but as I'm just getting started with the code base I lack a bit of information. My best guess is you are talking about the
If so, as far as I can see, that already get's only applied on public channels as rust-lightning/lightning/src/routing/scoring.rs Line 1330 in bf3bc42
Given that you're aware of how this works much better than I am, I suppose you are talking about something different? Cheers, |
Close, I think this issue is around the actual For context: generally, peers provide more privacy if they limit So, we should only apply the limit if we have any announced ('public') channels, i.e., can be considered a forwarding node. |
hey @SimonAdameit |
@jbesraa Unfortunately I haven't had the time recently and if I find some time to dedicate to the project, I could just pick another issue if this is already done. So if you or someone else wants to work on it, please go ahead! |
Hii, @jbesraa I am interested in this issue, I can try this issue if you are not taking it :) |
sure @Sharmalm, feel free to take this |
Thanks @jbesraa |
Don't think we should hold 112 on this. |
Hello everyone, |
If a channel isn't public, our "reduce max_value_in_flight to provide routed payments more privacy" thing doesn't make sense...cause the channel isn't routing payments. Thus, our default config should depend on if the channel is public here, IMO.
The text was updated successfully, but these errors were encountered: