Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Peers] Tech Debt: Rename node_id/their_node_id #705

Open
Tracked by #707
julianknutsen opened this issue Sep 16, 2020 · 1 comment
Open
Tracked by #707

[Peers] Tech Debt: Rename node_id/their_node_id #705

julianknutsen opened this issue Sep 16, 2020 · 1 comment

Comments

@julianknutsen
Copy link

As a developer, I want variable names to be consistent across the codebase so that it is easier to jump around and understand the code.

Definition of Done:

  • decide on name (counterparty_id/counterparty_node_id?)
  • do the rename

Tech Discussion:
@ariard suggested counterparty_node_id

@julianknutsen julianknutsen mentioned this issue Sep 16, 2020
18 tasks
@TheBlueMatt
Copy link
Collaborator

As of #633 the "correct" answer is counterparty/holyder for them/us and countersignatory/broadcaster for transactions (which have an "owner" which may or may not be us).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants