Fix #[warn(clippy::try_err)] in ser_macros.rs #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SGTM, can we set this clippy lint to required so that the lint CI check fails here? |
Codecov Report
@@ Coverage Diff @@
## main #1032 +/- ##
=======================================
Coverage 90.80% 90.81%
=======================================
Files 60 60
Lines 31460 31459 -1
=======================================
+ Hits 28568 28570 +2
+ Misses 2892 2889 -3
Continue to review full report at Codecov.
|
Some heavily used macros are using ? directly on an Err. Using a return is easier to read and removes hundreds of linter warnings. https://rust-lang.github.io/rust-clippy/master/index.html#try_err
TheBlueMatt
approved these changes
Aug 2, 2021
valentinewallace
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some heavily used macros are using
?directly on anErr. Using areturnis easier to read and removes hundreds of linter warnings.https://rust-lang.github.io/rust-clippy/master/index.html#try_err