Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify GossipVerifier types using APeerManager #2773

Merged
merged 1 commit into from Dec 5, 2023

Conversation

johncantrell97
Copy link
Contributor

This simplifies the types but also allows an end-user (RGS in this case) to use a PeerManager that does not use P2PGossipSync as their RoutingMessageHandler.

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (37150b4) 88.63% compared to head (6765967) 88.62%.

Files Patch % Lines
lightning-block-sync/src/gossip.rs 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2773      +/-   ##
==========================================
- Coverage   88.63%   88.62%   -0.01%     
==========================================
  Files         115      115              
  Lines       90446    90446              
  Branches    90446    90446              
==========================================
- Hits        80170    80161       -9     
- Misses       7875     7879       +4     
- Partials     2401     2406       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@TheBlueMatt TheBlueMatt merged commit 9942994 into lightningdevkit:main Dec 5, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants