Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for using text fields in alerts #19

Merged

Conversation

akwilliamson
Copy link
Contributor

This includes instructions for variations on text field initialization and chaining text fields with other Alert methods. Note: Don't merge this PR until #18 is merged.

This includes instructions for variations on text field initialization and chaining text fields with other Alert methods.
@eriksargent
Copy link

Fixes #15

eriksargent pushed a commit that referenced this pull request Jul 27, 2015
Update README.md for using text fields in alerts
@eriksargent eriksargent merged commit 4704923 into lightningkite:master Jul 27, 2015
@akwilliamson
Copy link
Contributor Author

I'm thinking eventually down the road (not necessarily at the moment) the README might be further organized by extrapolating the Alert and ActionSheet classes into their own exclusive sections as the LKAlertController functionality continues to evolve uniquely to each class.

Something like:
...

LKAlertController
  • Shared functionality
Alert
  • Functionality unique to Alert
ActionSheet
  • Functionality unique to ActionSheet

...

We can open a separate PR at the point where there is enough unique content to differentiate the two classes. What do you think?

@akwilliamson
Copy link
Contributor Author

I'm learning a lot. Thanks for letting me contribute!

@eriksargent
Copy link

I like that idea. I'll start working on that. Thanks for helping!

@akwilliamson akwilliamson deleted the Update-README-addTextField branch September 16, 2015 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants