Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: add base dir to aperture #59

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

carlaKC
Copy link
Contributor

@carlaKC carlaKC commented Oct 5, 2021

This PR adds a base dir to aperture for move convenient file placement.

There's always some thinking to so with our various file placement flags (specifically --configfile and --basedir), gone with the following logic:

  • Default to AppDir if nothing is set
  • If only --configfile is set, use AppDir for files, use custom config location and require that it exists
  • If only --basedir is set, look for aperture.yaml in basedir but do not require it
  • If --configfile and --basedir are set, use basedir for files and require --configfile exists

Reason for allowing a --configfile and --basedir is that custom config file allows you to set the name of your config file as well as location.

@carlaKC
Copy link
Contributor Author

carlaKC commented Oct 5, 2021

@guggero @ellemouton PTAL 🙏

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice, LGTM 🎉

@guggero guggero merged commit 526eb30 into lightninglabs:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants