Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies (LND v0.18.0-beta and co) #138

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

starius
Copy link
Contributor

@starius starius commented Jun 2, 2024

Updated versions:

  • lnd: v0.17.4-beta -> v0.18.0-beta
  • lnd/kvdb: v1.4.4 -> v1.4.8
  • lnd/tor: v1.1.2 -> v1.1.3
  • lnd/healthcheck: v1.2.3 -> v1.2.4
  • lnd/tlv: v1.1.1 -> v1.2.6
  • neutrino: v0.16.0 -> v0.16.1-0.20240425105051-602843d34ffd
  • neutrino/cache: v1.1.1 -> v1.1.2
  • lndclient: v0.17.4-1 -> v0.18.0-2
  • loop: v0.26.6-beta -> v0.28.3
  • loop/swapserverrpc: v1.0.5 -> v1.0.8
  • pool: v0.6.2-beta.0.20230329135228-c3bffb52df3a -> v0.6.5-beta.0.20240531084722-4000ec802aaa
  • pool/auctioneerrpc: v1.0.7 -> v1.1.2
  • aperture: v0.1.21-beta.0.20230705004936-87bb996a4030 -> v0.3.2-beta
  • replace of protobuf: v1.30.0-hex-display -> v1.33.0-hex-display
  • Go: 1.21 -> 1.22.3

Pool version v0.6.5-beta.0.20240531084722-4000ec802aaa was used because it uses LND v0.18.0-beta, not v0.18.0-beta.rc3.

Fixed imports and API changes.

Updated Go version in README.

Updated LND version in cmd/chantools/root.go.
Ran make docs.


Updated golangci-ling, because its old version crashed trying to parse Go 1.22.3 version:

level=error msg="Running error: context loading failed: failed to load packages: failed to load with go/packages: err: exit status 1: stderr: go: errors parsing go.mod:\n/build/go.mod:3: invalid go version '1.22.3': must match format 1.23\n"

lint: update configs, golangci-lint to v1.59.0
Remove deprecated and deactivated linters from .golangci.yml.
Ignore too noisy linters: protogetter, depguard, mnd.
Fix linter warnings.
Use timeout instead of deadline in .golangci.yml.


test: don't modify test data

Copy a file to temp directory before opening it.

Fix #139

@starius starius force-pushed the update-lnd-v0.18.0-beta branch 4 times, most recently from 5fbb198 to e63a879 Compare June 3, 2024 01:52
@starius starius marked this pull request as ready for review June 3, 2024 01:56
@guggero guggero self-requested a review June 3, 2024 07:17
@starius
Copy link
Contributor Author

starius commented Jun 3, 2024

Updated PR. Loop just released loop v0.28.3, using it instead of a non-tagged commit.

@starius
Copy link
Contributor Author

starius commented Jun 3, 2024

Updated PR. Updated LND to v0.18.0-beta.1.

@starius
Copy link
Contributor Author

starius commented Jun 5, 2024

Updated PR.

Updated lndclient to v0.18.0-2.
Changed the way golangci-lint is updated: pinned the version in go.mod, not in Dockerfile
Fixed issue #139 (don't modify test data files in tests).

@lightninglabs-deploy
Copy link

@guggero: review reminder

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the update!
Have one request, otherwise looks good to me 💯

go.mod Show resolved Hide resolved
Updated versions:

  - lnd: v0.17.4-beta -> v0.18.0-beta
  - lnd/kvdb: v1.4.4 -> v1.4.8
  - lnd/tor: v1.1.2 -> v1.1.3
  - lnd/healthcheck: v1.2.3 -> v1.2.4
  - lnd/tlv: v1.1.1 -> v1.2.6
  - neutrino: v0.16.0 -> v0.16.1-0.20240425105051-602843d34ffd
  - neutrino/cache: v1.1.1 -> v1.1.2
  - lndclient: v0.17.4-1 -> v0.18.0-2
  - loop: v0.26.6-beta -> v0.28.3
  - loop/swapserverrpc: v1.0.5 -> v1.0.8
  - pool: v0.6.2-beta.0.20230329135228-c3bffb52df3a ->
        v0.6.5-beta.0.20240531084722-4000ec802aaa
  - pool/auctioneerrpc: v1.0.7 -> v1.1.2
  - aperture: v0.1.21-beta.0.20230705004936-87bb996a4030 -> v0.3.2-beta
  - replace of protobuf: v1.30.0-hex-display -> v1.33.0-hex-display
  - Go: 1.21 -> 1.22.3

Pool version v0.6.5-beta.0.20240531084722-4000ec802aaa was used because it uses
LND v0.18.0-beta, not v0.18.0-beta.rc3.

Fixed imports and API changes.

Updated Go version in README.

Updated LND version in cmd/chantools/root.go.
Ran `make docs`.
Remove deprecated and deactivated linters from .golangci.yml.

Ignore too noisy linters: protogetter, depguard, mnd.

Fix linter warnings.

Use timeout instead of deadline in .golangci.yml.
Copy a file to temp directory before opening it.

Fix lightninglabs#139
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@guggero guggero merged commit d173f8c into lightninglabs:master Jun 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running unit tests changes wallet.db file committed into the repo
3 participants