chantools scbforceclose: extract close tx from SCB and sign it #95

starius · 2023-11-16T14:03:40Z

This is part of lightningnetwork/lnd#7658 (comment) implementation.

This PR depends on lightningnetwork/lnd#8183
(Field chanbackup.Single.CloseTxInputs is needed.)

I added chantools scbforceclose command, which extracts closing tx from SCB and signs it and optionally broadcasts.

New command:

chantools scbforceclose --help

$ chantools scbforceclose --help

If you are certain that a node is offline for good (AFTER you've tried SCB!)
and a channel is still open, you can use this method to force-close your
latest state that you have in your channel.db.

!!! WARNING !!! DANGER !!! WARNING !!!

If you do this and the state that you publish is not the latest state, then
the remote node could punish you by taking the whole channel amount if they
come online before you can sweep the funds from the time locked (144 - 2000
blocks) transaction or they have a watch tower looking out for them.

This should absolutely be the last resort and you have been warned!

Usage:
chantools scbforceclose [flags]

Examples:
chantools scbforceclose --multi_file channel.backup

Flags:
--apiurl string API URL to use (must be esplora compatible) (default "https://blockstream.info/api")
--bip39 read a classic BIP39 seed and passphrase from the terminal instead of asking for lnd seed format or providing the --rootkey flag
-h, --help help for scbforceclose
--multi_backup string a hex encoded multi-channel backup obtained from exportchanbackup for force-closing channels
--multi_file string the path to a single-channel backup file (channel.backup)
--publish publish force-closing TX to the chain API instead of just printing the TX
--rootkey string BIP32 HD root key of the wallet to use for decrypting the backup and signing tx; leave empty to prompt for lnd 24 word aezeed
--single_backup string a hex encoded single channel backup obtained from exportchanbackup for force-closing channels
--single_file string the path to a single-channel backup file

Global Flags:
-r, --regtest Indicates if regtest parameters should be used
-s, --signet Indicates if the public signet parameters should be used
-t, --testnet Indicates if testnet parameters should be used

The command extracts closing transactions from SCB, signs and prints them.

Example

Here is an example of using chantools scbforceclose in testnet to sign a force closing transaction and to publish it.

chantools --testnet scbforceclose --single_backup xxx --publish --apiurl https://blockstream.info/testnet/api

$ chantools --testnet scbforceclose --single_backup xxx --publish --apiurl https://blockstream.info/testnet/api 2023-12-31 18:06:04.121 [INF] CHAN: chantools version v0.12.1 commit Input your 24-word mnemonic separated by spaces: ***

Input your cipher seed passphrase (press enter if your seed doesn't have a passphrase):

Found 1 channel backups, 1 of them have close tx.

@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
If you are certain that a node is offline for good (AFTER you've tried SCB!)
and a channel is still open, you can use this method to force-close your
latest state that you have in your channel.db.

!!! WARNING !!! DANGER !!! WARNING !!!

If you do this and the state that you publish is not the latest state, then
the remote node could punish you by taking the whole channel amount if they
come online before you can sweep the funds from the time locked (144 - 2000
blocks) transaction or they have a watch tower looking out for them.

This should absolutely be the last resort and you have been warned!
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@

Type YES to proceed: YES
Signed transactions will be broadcasted automatically.
Type YES again to proceed: YES
xxx:0
xxxxxxxx

2023-12-31 18:06:28.796 [INF] CHAN: Published TX xxx, response: xxx

(To use --publish option in testnet, --apiurl should be adjusted. Hopefully newExplorerAPI from #107 is fixing this.)

TODOs

validate close transaction? Does the fact that it is signed and serialized imply that it is valid. I'm interested in a way to produce such transactions for all the channels just to make sure they are producible from SCB and are valid
README for scbforceclose command
deduplicate code between createSignDesc and LightningChannel.CreateSignDesc. See chantools forceclose --channeldb crashes on taproot channels: malformed signature: no header magic #108

guggero

Thanks for the two PRs!
I think both need some extra work but are on the right track.

cmd/chantools/forceclose.go

starius · 2023-12-31T20:29:43Z

I updated both PRs. Signing now happens in chantools scbforceclose. I put an example into PR's description.

@guggero Please take another look!

starius · 2024-06-18T23:44:46Z

Rebased for LND 0.18, fixed lint warnings.
Tested manually.

guggero

Great PR, looks very good.

Will test once lnd side has been updated.

guggero · 2024-06-28T11:12:47Z

cmd/chantools/scbforceclose.go

+
+	if s.CloseTxInputs == nil {
+		return nil, errors.New("channel backup does not have data " +
+			"needed to sign force sloe tx")


nit: s/sloe/close/

Fixed, moved to LND PR (commit chanbackup: add function SignCloseTx).

guggero · 2024-06-28T11:13:05Z

cmd/chantools/scbforceclose.go

+}
+
+func createTaprootNonceProducer(
+	s chanbackup.Single,


nit: formatting.

Fixed, moved to LND PR (commit chanbackup: add function SignCloseTx).

starius · 2024-07-07T04:13:13Z

Thanks for the review! I updated LND PR and this PR. The code producing signed transaction was moved to LND to use it in itest.

guggero

Love how minimal this now turned out 💯

LGTM pending some final manual tests (will attempt to do later today).

guggero

tACK, LGTM 🎉

To make things easier to debug, can you please apply the following diff as another commit? That will add the new data to the output of chantools dumpbackup.

dumpchanbackup.diff.txt

Will merge once the lnd PR is in.

guggero · 2024-07-16T19:42:34Z

cmd/chantools/scbforceclose.go

+		return errors.New("failed to read user input")
+	}
+	if strings.TrimSpace(userInput) != "YES" {
+		return errors.New("cancelled by user")


nit: improve error message slightly, perhaps something like "canceled by user, must type uppercase 'YES'"? Same below.

guggero · 2024-07-16T19:44:11Z

cmd/chantools/scbforceclose.go

+				s.FundingOutpoint, err)
+		}
+		txHex := hex.EncodeToString(buf.Bytes())
+		fmt.Println(s.FundingOutpoint)


I think we should prefix these values, otherwise it looks a bit misleading on the command line.
Now:

Type YES to proceed: YES 8821015bb99036728b00f4b1f68ab4e41d8573947f3f94fe0d4ec2f38c1f92d4:0 02000000000101d4921f8cf3c24e0dfe943f7f9473851de4b48af6b1f4008b723690b95b01218800000000000508b280044a010000000000002......

Suggestion:

Type YES to proceed: YES Channel point: 8821015bb99036728b00f4b1f68ab4e41d8573947f3f94fe0d4ec2f38c1f92d4:0 Raw transaction hex: 02000000000101d4921f8cf3c24e0dfe943f7f9473851de4b48af6b1f4008b723690b95b01218800000000000508b280044a01000000000.....

Implemented!

Remove MockSigner from Signer. MockSigner has MusigSessionManager is an embedded field, and it is the only part of MockSigner needed in Signer.

It can now be used as keychain.ECDHRing.

It will be reused in scbforceclose.

That will add the new data to the output of chantools dumpbackup.

starius · 2024-07-17T14:20:03Z

I rebased the PR, updated go replace to the latest lightningnetwork/lnd#8183 version.

Also included the suggested patch for dump.go. @guggero I put your name in Author field of the commit.

lightninglabs-deploy · 2024-07-31T15:03:33Z

@starius, remember to re-request review from reviewers when ready

This was referenced Nov 16, 2023

chanbackup, server, rpcserver: put close unsigned tx, remote signature and commit height to SCB lightningnetwork/lnd#8183

Open

[feature]: Include last state in close summary and exportchanbackup lightningnetwork/lnd#7658

Open

starius force-pushed the close-tx-in-static-backup branch from 4530889 to 31b20eb Compare November 16, 2023 14:31

guggero self-requested a review November 27, 2023 22:51

guggero reviewed Dec 12, 2023

View reviewed changes

cmd/chantools/forceclose.go Outdated Show resolved Hide resolved

cmd/chantools/forceclose.go Outdated Show resolved Hide resolved

cmd/chantools/forceclose.go Outdated Show resolved Hide resolved

starius force-pushed the close-tx-in-static-backup branch 3 times, most recently from 74d418b to 3e8ea11 Compare December 31, 2023 19:13

starius mentioned this pull request Dec 31, 2023

chantools forceclose --channeldb crashes on taproot channels: malformed signature: no header magic #108

Open

starius changed the title ~~chantools forceclose: extract close tx from SCB~~ chantools scbforceclose: extract close tx from SCB and sign it Dec 31, 2023

starius requested a review from guggero December 31, 2023 20:29

starius force-pushed the close-tx-in-static-backup branch from 3e8ea11 to dcc9b3b Compare January 2, 2024 02:39

guggero removed their request for review April 22, 2024 12:36

starius marked this pull request as draft June 3, 2024 01:56

starius force-pushed the close-tx-in-static-backup branch 2 times, most recently from b78f22b to 4b79ab4 Compare June 18, 2024 23:01

starius marked this pull request as ready for review June 18, 2024 23:44

starius requested a review from guggero June 18, 2024 23:45

guggero reviewed Jun 28, 2024

View reviewed changes

starius force-pushed the close-tx-in-static-backup branch from 4b79ab4 to 521d4c8 Compare July 7, 2024 04:10

starius requested a review from guggero July 7, 2024 04:13

guggero reviewed Jul 16, 2024

View reviewed changes

starius added 4 commits July 17, 2024 11:11

go.mod: depend on lnd with lightningnetwork/lnd#8183

22cb695

lnd: put MusigSessionManager to Signer

7bc8765

Remove MockSigner from Signer. MockSigner has MusigSessionManager is an embedded field, and it is the only part of MockSigner needed in Signer.

lnd/signer: add ECDH method

006e4c5

It can now be used as keychain.ECDHRing.

forceclose: factor out warnings to a const

aea9d08

It will be reused in scbforceclose.

starius and others added 2 commits July 17, 2024 11:17

new command: scbforceclose

1fe8248

dump: include close tx, commit sig, commit height

1049f12

That will add the new data to the output of chantools dumpbackup.

starius force-pushed the close-tx-in-static-backup branch from 521d4c8 to 1049f12 Compare July 17, 2024 14:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chantools scbforceclose: extract close tx from SCB and sign it #95

chantools scbforceclose: extract close tx from SCB and sign it #95

starius commented Nov 16, 2023 •

edited

Loading

guggero left a comment

starius commented Dec 31, 2023

starius commented Jun 18, 2024

guggero left a comment

guggero Jun 28, 2024

starius Jul 7, 2024

guggero Jun 28, 2024

starius Jul 7, 2024

starius commented Jul 7, 2024

guggero left a comment

guggero left a comment

guggero Jul 16, 2024

starius Jul 17, 2024

guggero Jul 16, 2024

starius Jul 17, 2024

starius commented Jul 17, 2024

lightninglabs-deploy commented Jul 31, 2024

chantools scbforceclose: extract close tx from SCB and sign it #95

Are you sure you want to change the base?

chantools scbforceclose: extract close tx from SCB and sign it #95

Conversation

starius commented Nov 16, 2023 • edited Loading

Example

TODOs

guggero left a comment

Choose a reason for hiding this comment

starius commented Dec 31, 2023

starius commented Jun 18, 2024

guggero left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

starius commented Jul 7, 2024

guggero left a comment

Choose a reason for hiding this comment

guggero left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

starius commented Jul 17, 2024

lightninglabs-deploy commented Jul 31, 2024

starius commented Nov 16, 2023 •

edited

Loading