Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go to 1.19 in Dockerfile #167

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

andrei-21
Copy link
Contributor

Currently docker build fails with:

$ docker build .
...
github.com/lightningnetwork/lnd/discovery
# github.com/lightningnetwork/lnd/discovery
/go/pkg/mod/github.com/lightningnetwork/lnd@v0.16.0-beta/discovery/gossiper.go:644:15: undefined: atomic.Uint64
note: module requires Go 1.19
make: *** [Makefile:55: build] Error 2
The command '/bin/sh -c apk add --no-cache --update alpine-sdk     git     make     gcc &&  cd /go/src/github.com/lightninglabs/faraday &&  make &&  make install' returned a non-zero code: 2

Pull Request Checklist

  • Update MinLndVersion if your PR uses new RPC methods or fields of lnd.

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 🎉

@guggero guggero requested a review from ellemouton April 21, 2023 10:05
Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guggero guggero merged commit 2b75f20 into lightninglabs:master Apr 21, 2023
5 checks passed
@andrei-21 andrei-21 deleted the fix/docker-build branch April 21, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants