accounting: increase client gRPC max receive size, bump lndclient to fix large message issue #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're using this successfully to enable us to work with large nodes that have a lot of data. Good to merge imo, though definitely pagination is needed as the memory requirements are ever increasing with the current implementation that fetches every single onchain transaction. |
guggero
force-pushed
the
grpc-max-receive-size
branch
from
ea81404
to
bb86712
Compare
|
Updated to use the tagged version of |
bhandras
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lightninglabs/lndclient#164.Fixes #177, at least temporarily. We should start paginating calls to
ListTransactions.Pull Request Checklist
MinLndVersionif your PR uses new RPC methods or fields oflnd.