config: allow tls cert validity duration to be configured #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
approved these changes
Feb 14, 2024
config.go
Outdated
| TLSExtraDomains []string `long:"tlsextradomain" description:"Adds an extra domain to the generated certificate."` | ||
| TLSAutoRefresh bool `long:"tlsautorefresh" description:"Re-generate TLS certificate and key if the IPs or domains are changed."` | ||
| TLSDisableAutofill bool `long:"tlsdisableautofill" description:"Do not include the interface IPs or the system hostname in TLS certificate, use first --tlsextradomain as Common Name instead, if set."` | ||
| TLSCertDuration time.Duration `long:"tlscertduration" description:"The duration for which the auto-generated TLS certificate will be valid for"` |
There was a problem hiding this comment.
micro-nit: all the other descriptions end with a full stop.
There was a problem hiding this comment.
Ok, updated in new squashed commit. I actually pulled it over from lnd codebase, where none of the descriptions end in a full stop!
There was a problem hiding this comment.
Yeah, I know, this isn't very consistent across projects... But I guess it's nice to at least have consistency within the same block of config options.
mrfelton
force-pushed
the
cert-duration
branch
from
e035465
to
59a2d5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #184
This pull request includes changes to the
config.gofile that primarily focus on renaming and reusing theDefaultAutogenValidityconstant asdefaultTLSCertDurationandTLSCertDuration. The changes allow for the duration of the auto-generated TLS certificate to be customized.Here are the key changes:
DefaultAutogenValiditytodefaultTLSCertDurationand updated its comment to reflect the new name.TLSCertDurationin theConfigstruct, which allows the user to set the duration for the auto-generated TLS certificate.TLSCertDurationtodefaultTLSCertDurationin theDefaultConfigfunction.DefaultAutogenValiditywithcfg.TLSCertDurationin theloadCertWithCreatefunction, which generates the TLS certificate. This allows the certificate's duration to be set based on theTLSCertDurationvalue in theConfigstruct.