Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zpay32: initial seeds #5

Merged
merged 2 commits into from
May 25, 2023
Merged

Conversation

morehouse
Copy link
Contributor

@morehouse morehouse commented Apr 18, 2023

Seeds were generated from 200+ CPU hours of fuzzing using a shared corpus. The corpus was then minimized separately for each fuzz target using the script from #4.

Note that the corpora are identical, as the fuzzer was unable to get past the bech32 checksum verification during decoding (and thus never got to the encoding part).

These fuzz targets would likely benefit from hand-picked seeds and/or bypassing the checksum verification. I plan to work on these improvements in the near future.

Ref #1, lightningnetwork/lnd#7452.

Generated from 200+ CPU-hours of fuzzing using a corpus shared with
the FuzzEncode target, then minimized separately from FuzzEncode.
Generated from 200+ CPU-hours of fuzzing using a corpus shared with
the FuzzDecode target, then minimized separately from FuzzDecode.
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@guggero
Copy link
Member

guggero commented May 24, 2023

cc @Crypt-iQ, @Roasbeef

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🪛

@Roasbeef Roasbeef merged commit 0cfd5e9 into lightninglabs:main May 25, 2023
@morehouse morehouse deleted the zpay32_seeds branch May 25, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants