New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Build: Get zombie channel count from network info #50

Merged

Roasbeef merged 1 commit into master from fix-zombiechannels

Dec 9, 2019

Contributor

carlaKC commented Dec 9, 2019

docker-compose build is failing with:

# github.com/lightninglabs/lndmon/collectors
../../collectors/graph_collector.go:297:15: resp.NumZombies undefined (type *lnrpc.ChannelGraph has no field or method NumZombies)
ERROR: Service 'lndmon' failed to build: The command '/bin/sh -c cd /go/src/github.com/lightninglabs/lndmon/cmd/lndmon && go build' returned a non-zero code: 2

Probably related to #49, although I didn't check all the way back to v0.7.1 for the proto change so I will get somebody else to reproduce.


          collectors: get zombie chans from network info

4a5f7fb

carlaKC requested a review from cfromknecht

December 9, 2019 13:02

Roasbeef approved these changes

View reviewed changes

Member

Roasbeef left a comment

LGTM 🏔

We should get up a basic travis build just to catch things like this before merge.

Roasbeef merged commit 38995c4 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment