Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add --disablegraph #67

Merged
merged 1 commit into from Mar 1, 2021

Conversation

joostjager
Copy link
Contributor

lndmon is known (reported by multiple users) to cause high cpu load problems for lnd. This is cause by the DescribeGraph call which is really too heavy for frequent scraping.

This PR adds a command line flag to disable the graph metrics.

@joostjager
Copy link
Contributor Author

@carlaKC how about this one? I believe almost every user of lndmon has run into this

Copy link
Contributor

@carlaKC carlaKC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what hardware are you running on where you get issues with graph metrics?

I think this is worth adding, because we're likely not going to get around to streamlining the graph metrics with high prio.

@joostjager
Copy link
Contributor Author

It is running on a dual-core VM. But I don't think that a full graph fetch at a typical scrape interval is ever going to work.

@carlaKC
Copy link
Contributor

carlaKC commented Mar 1, 2021

But I don't think that a full graph fetch at a typical scrape interval is ever going to work.

Yeah, definitely not ideal to poll the whole graph. Would be great to move a few of the metrics over to subscriptions, but it's difficult to find the time when it's mostly working.

@carlaKC carlaKC merged commit c607b4f into lightninglabs:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants