Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lndmon: additional monitoring for closing channel balances #91

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

bhandras
Copy link
Member

This PR extends the channels collector to also monitor balances of individual channels that are waiting for force close resolution and channels that have been cooperatively closed.

This commit extends the channels collector with two additional metrics
to be able to monitor channel balances waiting to close and channel
balances currently in limbo due to being force closed.
@bhandras bhandras marked this pull request as ready for review November 22, 2022 12:29
anchorStateToString(forceClose.AnchorState),
forceClose.ChannelInitiator.String(),
forceClose.PubKeyBytes.String(),
fmt.Sprintf("%d", forceClose.BlocksUntilMaturity),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super happy about this but haven't found a way to add a non text label. Not a huge deal as we can still track amount changes and display maturity in a table view but would be nice to be able to track it as a number in the same metric.

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, LGTM 🎉

@bhandras bhandras merged commit f36b0ca into master Nov 23, 2022
@bhandras bhandras deleted the limbo-balance branch November 23, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants