blockmanager: avoid dereferencing nil checkpoint hash #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a nil pointer dereference that could happen for nets having no checkpoints, where we would attempt to dereference the pointer to a nil hash. We fix this by not dereferenceing before the height has been checked. Comments are updated to reflect the change.
halseth
force-pushed
the
checkpoint-nil-pointer-dereference
branch
2 times, most recently
from
e2578de
to
328dc45
Compare
This was referenced Oct 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a nil pointer dereference that could happen for nets
having no checkpoints, where we would attempt to dereference the pointer
to a nil hash.
We fix this by not dereferenceing before the height has been checked.
Comments are updated to reflect the change.