Check filter header checkpoints against hardcoded list #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpaulino
reviewed
Jun 18, 2019
ControlCFHeader controls the passed filter header against a list of hardcoded checkpoints, that we can use to determine peers serving invalid filterheaders.
Before starting to compare filter checkpoints our peers are serving, we do a quick check against the filter header checkpoints we have.
halseth
force-pushed
the
filter-header-checkpoints
branch
from
e47c5a9
to
40060ce
Compare
|
PTAL @wpaulino |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before starting to compare filter checkpoints our peers are serving, we
do a quick check against a list of filter header checkpoints we have.
Note that this PR doesn't actually add the checkpoints, these should be cross checked from different nodes.