New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockmanager: remove queryResponse length check #99

Merged
merged 1 commit into from Sep 28, 2018

Conversation

Projects
None yet
4 participants
@halseth
Contributor

halseth commented Sep 25, 2018

queryResponses was recently changed from being a slice to a map.
Previously a length check was performed to make sure we didn't index out
of bounds, but after the change to using a map this is no longer
correct.

This would be apparent doing header download from multiple peers, as
responses would come asynchronously, and the headers wouldn't be written
because of this check.

@coveralls

This comment has been minimized.

coveralls commented Sep 25, 2018

Coverage Status

Coverage decreased (-0.2%) to 70.053% when pulling b10696e on halseth:queryresponse-filter-check into bee0ed1 on lightninglabs:master.

blockmanager: remove queryResponse length check
queryResponses was recently changed from being a slice to a map.
Previously a length check was performed to make sure we didn't index out
of bounds, but after the change to using a map this is no longer
correct.

This would be apparent doing header download from multiple peers, as
responses would come asynchronously, and the headers wouldn't be written
because of this check.

@halseth halseth force-pushed the halseth:queryresponse-filter-check branch from 86e1457 to b10696e Sep 26, 2018

@Roasbeef

LGTM 🐉

@Roasbeef Roasbeef merged commit 29105cb into lightninglabs:master Sep 28, 2018

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.2%) to 70.053%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment