blockmanager: remove queryResponse length check #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfromknecht
reviewed
Sep 25, 2018
queryResponses was recently changed from being a slice to a map. Previously a length check was performed to make sure we didn't index out of bounds, but after the change to using a map this is no longer correct. This would be apparent doing header download from multiple peers, as responses would come asynchronously, and the headers wouldn't be written because of this check.
halseth
force-pushed
the
queryresponse-filter-check
branch
from
86e1457
to
b10696e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
queryResponses was recently changed from being a slice to a map.
Previously a length check was performed to make sure we didn't index out
of bounds, but after the change to using a map this is no longer
correct.
This would be apparent doing header download from multiple peers, as
responses would come asynchronously, and the headers wouldn't be written
because of this check.