Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lease chain fee estimation calculation includes account version #434

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Jan 19, 2023

I need to add a test to cover this aspect:

what version of the account will be stored in the batch if in that batch the account is auto-upgraded from P2WSH (version 0) to P2TR (version 1)

This PR addresses this issue: #431

The account versions from the spending accounts snapshot will be used in estimating on-chain fees.
Account version is taken from a snapshot of spending account states. This is because the account might be updated to a new version within the batch.
@ffranr ffranr force-pushed the issue431_lease_chain_fee_estimation branch from 0e7a18b to 1a14e73 Compare January 19, 2023 14:13
@ffranr
Copy link
Contributor Author

ffranr commented Jan 19, 2023

I think the code should be correct at this point. I need to add an itest to subasta to make sure that account updates are handled correctly.

I think that the chain fee estimation code should be refactored out of the prepareLeasesResponse method. And then unit tests can be written that the correct fees are estimated for a given batch.

@lightninglabs-deploy
Copy link
Collaborator

@positiveblue: review reminder

@lightninglabs-deploy
Copy link
Collaborator

Closing due to inactivity

8 similar comments
@lightninglabs-deploy
Copy link
Collaborator

Closing due to inactivity

@lightninglabs-deploy
Copy link
Collaborator

Closing due to inactivity

@lightninglabs-deploy
Copy link
Collaborator

Closing due to inactivity

@lightninglabs-deploy
Copy link
Collaborator

Closing due to inactivity

@lightninglabs-deploy
Copy link
Collaborator

Closing due to inactivity

@lightninglabs-deploy
Copy link
Collaborator

Closing due to inactivity

@lightninglabs-deploy
Copy link
Collaborator

Closing due to inactivity

@lightninglabs-deploy
Copy link
Collaborator

Closing due to inactivity

@guggero
Copy link
Member

guggero commented Sep 26, 2023

!lightninglabs-deploy mute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants