tarofreighter: introduce new package to house batched sending logic, add coin selection interface + impl #113
Conversation
Roasbeef
force-pushed
the
coin-select
branch
from
1e03723
to
9eac62a
Compare
| // input in a transaction. | ||
| // | ||
| // To obtain this, we'll first do another query to fetch all | ||
| // the _other_ assets that are anchored at the anchor point for |
There was a problem hiding this comment.
Won't this query also contain the asset already selected in matchingAssets as that has the same anchor point? I guess it doesn't really matter for the logic here (as far as I can tell), it's just that the comment is a bit misleading.
There was a problem hiding this comment.
Ah yeah it would unless we extend the query to exclude things. Below this is taken into account, as we'll take everything here to construct the new taro root for this particular output. Otherwise we'd need to remember to add this asset again. So for now it's duplicate in memory.
tarodb/assets_store.go
Outdated
| @@ -912,6 +913,7 @@ func (a *AssetStore) SelectCommitment( | |||
|
|
|||
| // First, we'll map the commitment constraints to our database query | |||
| // filters. | |||
| //var assetFilter QueryAssetFilters | |||
Heh yeh, I think eventually I'll make an issue that a I think we'll also want to eventually break out that mega query into a view. Then all the new clauses can be a super set of that, putting it all in a new |
Roasbeef
force-pushed
the
coin-select
branch
2 times, most recently
from
6b248c0
to
4feb85f
Compare
…ly key This'll be useful for coin selection as we'll be able to search through the assets based on some key parameters. This call can also eventually serve as the basis for other queries like the balance of all the assets with a given ID, etc, etc.
We'll start to extend with even more queries, so we might as well switch up the name.
This sets up for an upcoming new query to use all this functionality without duplicating it all.
In this commit, we add an implementation of CommitmentSelector for the main assets store. Along the way, we extend the new QueryAsset method to allow us to select all the assets anchored to a given outpoint. We can then use this to fetch all the other assets that are committed alongside a main asset, as we need to also return the full taro commitment for each selected asset. This implementation will be used to do proper coin selection for the upcoming batched send logic.
Roasbeef
force-pushed
the
coin-select
branch
from
4feb85f
to
b897f80
Compare
|
Thx for the review y'all, I've made some follow up issues to address other items, so we can move forward with the integration elsewhere. Related to #48 I think we prob want to make that mega query into a simpler view, then make the other future queries (balance for assets, etc) on top of that. |
In this PR, we add a new package
tarofreighterthat'll house the upcoming batched sending logic. The first addition in this package is theCommitmentSelectorinterface that abstracts away the process of coin selection. In addition to an asset input, we also need: the internal key, the anchor point, and also the taro commitment of all other assets along side it.This is the half of the DB level changes we need to complete the state machine. The second half will come in the form of "spend" logic to modify an input asset, and also re-anchor (along w/ a proof file extension) any other assets that were spent along the way.
Missing components: