multi: move more functionality into taroscript, add TxValidator interface #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
approved these changes
Sep 12, 2022
4 tasks
Roasbeef
approved these changes
Sep 13, 2022
| @@ -170,6 +172,9 @@ func initSpendScenario(t *testing.T) spendData { | |||
| // Generate matching TaroCommitments. | |||
| updateScenarioCommitments(t, &state) | |||
|
|
|||
| // Validator instance needed to call the Taro VM. | |||
| state.validator = &taro.ValidatorV0{} | |||
There was a problem hiding this comment.
Doesn't happen rn, but I think this would create a circular dep if/when the main package ever imports taroscript. Not something we need to worry about rn tho.
jharveyb
force-pushed
the
validator-interface
branch
from
8382442
to
d1d1803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spun off from ongoing state machine work.
In this PR, we refactor functions from the VM and Address package to resolve underlying dependency issues and potential cycles. We also introduce the
TxValidatorinterface, to simplify use of the Taro VM from the send state machine.