Small fixes and cleanup #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A workaround was added during debugging to allow constructing a partial proof when the block is not known yet. This has been fixed in another way (creating a fake block on at the call site) in the meantime, so this workaround is no longer needed here.
jharveyb
approved these changes
Sep 22, 2022
| queries: "tarodb/sqlite/queries" | ||
| version: "2" | ||
| sql: | ||
| - engine: "postgresql" |
There was a problem hiding this comment.
Looks equivalent, but why is the engine PostgreSQL here in general?
There was a problem hiding this comment.
When we started the project, the sqlite engine wasn't ready. However turns out, that we can use the postgres engine as is, since we're not using any sqlite specific features yet. This also means we can ideally "easily" add another layer of scaffolding and then support postgres as well w/ minimal changes.
|
|
||
| // If one of the family keys is not nil while the other one is, then we | ||
| // can already exit here as we know things won't match up further. | ||
| if !famKeyBothNil && !famKeyNoneNil { |
There was a problem hiding this comment.
IMO the other representation is easier to read b/c only one negation:
!(famKeyBothNil || famKeyNoneNil)
But not a blocker.
|
|
||
| // TestAddrMatchesAsset tests that the AddrMatchesAsset function works | ||
| // correctly. | ||
| func TestAddrMatchesAsset(t *testing.T) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few smaller things:
sqlcversion tov1.15.0(can use new config format, butsqliteengine doesn't understandWITHclauses yet, so we can't use that).tarocli addrs receivescommand to show inbound asset transfers.