multi: list asset transfers through RPC + cli #158
Conversation
bhandras
force-pushed
the
list-transfers
branch
from
bd8461b
to
1a461de
Compare
| return err | ||
| } | ||
| // Keep the old proofs as a reference for when we list past | ||
| // transfers. |
There was a problem hiding this comment.
Still getting through the the diff, but as is we might end up storing slightly redundant data, since these are the proof suffixes (new state transitions). This would only really be for the sender though, since the receiver's aren't stored in the DB though.
|
|
||
| // QueryParcels returns the set of confirmed or unconformed parcels. | ||
| func (a *AssetStore) QueryParcels(ctx context.Context, | ||
| pending bool) ([]*tarofreighter.OutboundParcelDelta, error) { |
| @@ -936,6 +937,8 @@ func (p *ChainPorter) stateStep(currentPkg sendPackage) (*sendPackage, error) { | |||
| }, | |||
| }, | |||
| TapscriptSibling: currentPkg.InputAsset.TapscriptSibling, | |||
| // TODO(bhandras): use clock.Clock instead. | |||
| TransferTime: time.Now(), | |||
There was a problem hiding this comment.
Good move to also move this into the application layer so the DB doesn't explicitly need to worry about time itself.
|
|
||
| // The new Taro root that commits to the set of modified and unmodified | ||
| // assets. | ||
| bytes taro_root = 4; |
There was a problem hiding this comment.
Totally non-blocking, but I'm thinking we also want to start showing the branch hash and also value here. Then people can spot check the roots to see things like the total number of units, etc.
| repeated AssetSpendDelta asset_spend_deltas = 6; | ||
| } | ||
|
|
||
| message AssetSpendDelta { |
There was a problem hiding this comment.
In the future I think we also want to add more information here like splits, etc -- but this is a solid base to build off of.
This PR adds a new RPC and the matching cli command to list pending and past transfers. (repoen of #135 after the repo went public).