Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap math.MaxInt64 in int64() for 32-bit cross-compilation #167

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

jacohend
Copy link
Contributor

We must wrap math.MaxInt64 calls in int64() for rpi/arm/32-bit support, otherwise cross-compilation yields this error:

cmd/tarocli/addrs.go:144:9: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in assignment (overflows)

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Though I'm not sure we should explicitly support a 32-bit architecture. With lnd this lead to problems before with some limitations around max DB size. What architecture/device are you targeting?

cmd/tarocli/addrs.go Outdated Show resolved Hide resolved
@jacohend
Copy link
Contributor Author

I see, the smaller 32 bit max make sense as a problem for db limits.

What architecture/device are you targeting?

Arm 6 and 7, raspbian.

@Roasbeef Roasbeef merged commit 556d3ae into lightninglabs:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants