build: get binary build info from debug/buildinfo
#170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhandras
reviewed
Oct 17, 2022
|
|
||
| install: | ||
| @$(call print, "Installing tarod and tarocli.") | ||
| $(GOINSTALL) -tags="${tags}" $(LDFLAGS) $(PKG)/cmd/tarod | ||
| $(GOINSTALL) -tags="${tags}" $(LDFLAGS) $(PKG)/cmd/tarocli | ||
| $(GOINSTALL) -tags="${tags}" $(RELEASE_LDFLAGS) $(PKG)/cmd/tarod |
There was a problem hiding this comment.
Two things, when I run make install I get:
$ make install
fatal: No names found, cannot describe anything.
Installing tarod and tarocli.
GO111MODULE=on go install -v -tags="" -s -w -buildid= -X github.com/lightninglabs/taro/build.Commit= github.com/lightninglabs/taro/cmd/tarod
flag provided but not defined: -s
usage: go install [build flags] [packages]
Run 'go help install' for details.
make: *** [Makefile:95: install] Error 2
And also when I just make the ./tarod-debug --version command doesn't anymore have the commit set.
Bump lnd to `609cc8b883c7e6186e447e8d7e6349688d78d4fd` in master, which already includes the change for including the build tags info without using `-ldflags`. This is needed for running the itests, which build lnd and won't have the build tags replicated a `-ldflags`.
By using the `debug/buildinfo` package we do not have to relay on setting custom ldflags. Unfortunately, there is no `vcs.tags` settings so we need to still pass the output of `git describe --tags --dirty` as an ldflag.
|
I updated lnd to ensure that it had the latest changes in master. However, I am not sure if there is anything that is incompatible with the project yet 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using the
debug/buildinfopackage we do not have to rely on setting custom ldflags.Unfortunately, there is no
vcs.tagssettings so we need to still pass the output ofgit describe --tags --dirtyas an ldflag.Note: this change was already merged in LND and the lnd package need to be updated in
go.modfor this to work.