tarodb: add chain_fees to chain_txns
#184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
reviewed
Oct 27, 2022
| @@ -0,0 +1,2 @@ | |||
| ALTER TABLE chain_txns ADD chain_fees INTEGER; | |||
|
|
|||
There was a problem hiding this comment.
We're still in alpha and already know that users will need to drop their DB state with the next release. So this can be added directly to the original migration file.
|
@guggero: review reminder |
Populate the new field using the funded PSBT data.
Store on-chain fees as a separate column so we can directly execute queries in our database using this value. Not all chain tx will have this field populated. We will store the fees only for the tx that we create (minting and trasfer operations but not importing).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store how much we spent in on-chain fee for minting/transfers operations.
Fixes #144
Affects #177