Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itest: support multiple proof courier service types #279

Merged
merged 2 commits into from
May 23, 2023

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented May 16, 2023

This commit adds a new proof courier harness interface which will allow the integration tests to support multiple different proof courier service types. It also ensures that each test case has its own proof courier service instance.

This commit also removes the need to specify a proof courier when starting a new taro node during a test case. By default, the test harness will be inspected for an existing proof courier.

@ffranr ffranr requested review from Roasbeef and guggero May 16, 2023 17:06
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, almost ready. Just a question about whether we actually need the Start() method on the aperture harness?

itest/test_harness.go Show resolved Hide resolved
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

proof/aperture.go Show resolved Hide resolved
@ffranr ffranr requested a review from jharveyb May 17, 2023 18:05
Copy link
Collaborator

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending some nits. Good to have a more robust itest setup 💯

itest/test_harness.go Outdated Show resolved Hide resolved
itest/test_harness.go Outdated Show resolved Hide resolved
itest/test_harness.go Outdated Show resolved Hide resolved
This commit adds a new proof courier harness interface which will allow
the integration tests to support multiple different proof courier
service types. It also ensures that each test case has its own proof
courier service instance.

This commit also removes the need to specify a proof courier when
starting a new taro node during a test case. By default, the test
harness will be inspected for any existing proof courier.
@ffranr ffranr added this pull request to the merge queue May 23, 2023
Merged via the queue into lightninglabs:main with commit 92ea9f4 May 23, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants