-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
itest: support multiple proof courier service types #279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, almost ready. Just a question about whether we actually need the Start()
method on the aperture harness?
441f47e
to
fb12d1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending some nits. Good to have a more robust itest setup 💯
fb12d1f
to
c2f5b3c
Compare
This commit adds a new proof courier harness interface which will allow the integration tests to support multiple different proof courier service types. It also ensures that each test case has its own proof courier service instance. This commit also removes the need to specify a proof courier when starting a new taro node during a test case. By default, the test harness will be inspected for any existing proof courier.
c2f5b3c
to
f7edff9
Compare
This commit adds a new proof courier harness interface which will allow the integration tests to support multiple different proof courier service types. It also ensures that each test case has its own proof courier service instance.
This commit also removes the need to specify a proof courier when starting a new taro node during a test case. By default, the test harness will be inspected for an existing proof courier.