mint: fix REST encoding of mint RPC #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to #286 which allowed developers to specify any raw bytes as a hex string in the REST API (instead of the library default of base64). The only area where that change didn't apply is the URI part of REST calls. For those we need to use a string field to support hex encoding, the same way we already did for the universe REST API.
This is a purely cosmetic change that just makes it a bit more apparent that we are using different URIs for the same gRPC method to make usage of the universe API easier for REST users.
jharveyb
approved these changes
May 24, 2023
|
@Roasbeef: review reminder |
Roasbeef
approved these changes
Jun 1, 2023
|
|
||
| - selector: universerpc.Universe.QueryAssetRoots | ||
| get: "/v1/taproot-assets/universe/roots/group-key/{id.group_key_str}" | ||
| additional_bindings: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #286 which allowed developers to specify any raw
bytes as a hex string in the REST API (instead of the library default of
base64).
The only area where that change didn't apply is the URI part of REST
calls. For those we need to use a string field to support hex encoding,
the same way we already did for the universe REST API.