universe: fix potential loop scoping bugs, add additional debug logging #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we rename the chanutils package to be just `fn`. This is shorter so means we'll run into the line limit less. The package also now contains general generic functions, so this new name matches better.
This should help us figure out what's going on with some of these error messages.
Roasbeef
force-pushed
the
universe-debugging
branch
from
8558a96
to
4f39b9f
Compare
guggero
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit we rename the
chanutilspackage tofn, as it's much shorter, and how houses generic functions that deal with more than just channels.We then attempt to fix some potential loop scoping bugs in the universe code. Finally, we add some logging to print out the id+key for the fail universe log sync events.