tapdb/universe: fix universe event logging for grouped assets #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we fix the universe event logging for grouped assets. As is, when we go to insert assets with a group, then the "first" inserted asset is what's known as the `asset_id` in the `universe_roots` table. When we go to log a proof insert/sync event, and the even only has an asset ID, we may end up with a failed query, as only the "first" asset ID would return the row we want. In order to fix this, rather than trying to match the asset ID with a root, we instead find the _leaf_ for that asset ID, then use that to get the primary key of the universe root via it's foreign key ref.
|
These errors are no longer present when registering asset issuance after minting, but I still see them for universe sync events. Can reproduce with taproot-assets/universe/syncer.go Line 189 in c037025 |
guggero
approved these changes
Jun 12, 2023
JHB didn't block PR but will need to continue #354 |
|
This has been deployed to testnet and staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we fix the universe event logging for grouped assets. As is, when we go to insert assets with a group, then the "first" inserted asset is what's known as the
asset_idin theuniverse_rootstable. When we go to log a proof insert/sync event, and the even only has an asset ID, we may end up with a failed query, as only the "first" asset ID would return the row we want.In order to fix this, rather than trying to match the asset ID with a root, we instead find the leaf for that asset ID, then use that to get the primary key of the universe root via it's foreign key ref.
Fixes #313