Asset metadata overwrite fix #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to be careful with the ON CONFLICT ... DO UPDATE SET clauses, if we blindly set xxxx = EXCLUDED.xxxx then we risk overwriting existing valid values with NULL. To fix a specific problem with the asset meta, we use COALESCE instead to avoid overwriting existing values with NULL.
ffranr
approved these changes
Jun 19, 2023
|
Woot! Confirmed this works locally as well. Thanks! |
jharveyb
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #368.
As @habibitcoin already correctly identified, one of our SQL queries is incorrect and overwrites valid meta information with
NULLwhen importing a proof.