Fix multiple small issues with release, prepare for 0.2.2-alpha #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids including the itest package in the production build of tapd.
ffranr
approved these changes
Jun 23, 2023
Comment on lines
+80
to
+83
| ######################## | ||
| # cross compilation | ||
| ######################## | ||
| cross-compile: |
There was a problem hiding this comment.
release-build instead of cross-compile?
There was a problem hiding this comment.
This naming is from lnd where we actually have a release build (which creates a GitHub release and uploads the binaries to it) which is only triggered on pushed tags. So to distinguish that action from the CI step that is executed on every PR, we call this cross-compile instead. The make goal is the same, but the intent here is to cross compile to all release platforms (but the result is then discarded).
jharveyb
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #377.
Adds some Golang version bumps that were missed in #375 and updates the comments on what files such a bump needs to update.
Also makes sure that we catch release compilation issues early by running the release build in CI.
Since there was already a tag pushed for
v0.2.1-alpha, we need to bump the version tov0.2.2-alpha.