multi: concretely define split commitments, add routines to generate+verify them #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
commented
Jun 24, 2022
|
|
||
| // RootAsset is the asset containing the root of the split commitment | ||
| // tree from which the `Proof` above was computed from. | ||
| RootAsset Asset |
There was a problem hiding this comment.
Leaving this trail here, but: we could opt to just leave this out of the actual encoding as the proof file and VM context will be able to obtain this information for verification purposes. Leaving it in place for now tho.
Doesn't seem to be working properly, and we'll also need to manually handle some files due to an issue in SQL itself.
…tSet We actually want a real type here: this isn't attempting to be used for refactoring or references some external concrete type.
One other case we need to address is fully spending an input Taro UTXO using the on-chain address flow: in this case the sender no longer has an asset to use to commit to the new split set. They may need to retain a dummy zero value asset split just for that transition, then can drop it later.
Roasbeef
force-pushed
the
split-commitments
branch
from
cc1258d
to
15abb8e
Compare
|
Pushed up some commits adding bread crumbs and fixing up some of my comments from the old PR. |
dstadulis
pushed a commit
that referenced
this pull request
May 16, 2023
…handling Fix asset commitment group handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #27.
Fixes #3