Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 64bit primary keys in DB #548

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Use 64bit primary keys in DB #548

merged 4 commits into from
Oct 4, 2023

Conversation

guggero
Copy link
Member

@guggero guggero commented Oct 4, 2023

Fixes #533.

@guggero
sqlc: use BIGINT for all primary and foreign keys
307677c 
We use a BIGINT for all our primary and foreign keys, as that will
generate int64 types in the generated sqlc code.
We'll use translation rules to translate the primary keys into actually
auto-incrementing types for the two supported DB backends:

Postgres:
	BIGINT PRIMARY KEY	==>	BIGSERIAL PRIMARY KEY

SQlite:
	BIGINT PRIMARY KEY	==>	INTEGER PRIMARY KEY
@guggero
multi: use int64 for database IDs
8bc446a
@guggero
tapdb: use type replacement for BIGINT type
aceb2c0
@guggero
tapdb: add unit test for 64bit primary keys
6993be2
Roasbeef
Roasbeef approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦜

tapdb/sqlite.go
@@ -131,8 +131,12 @@ func NewSqliteStore(cfg *SqliteConfig) (*SqliteStore, error) {
return nil, err
}

sqliteFS := newReplacerFS(sqlSchemas, map[string]string{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

Minimal, yet very useful abstraction!

@Roasbeef Roasbeef merged commit affe4f9 into main Oct 4, 2023
14 checks passed
@guggero guggero deleted the use-64bit-primary-keys branch October 5, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roasbeef Roasbeef Roasbeef approved these changes

@ffranr ffranr Awaiting requested review from ffranr

Assignees
No one assigned
Labels
None yet
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature]: add support for int64 ids to tapdb
2 participants
@guggero @Roasbeef