Fix instances of time.Now() which should be set to UTC

[ffranr]

Closes #541

I have confirmed that the failing unit test now passes.

I think we should enforce UTC location in clock.NewTestClock (LND). Thoughts on this @guggero ?

[guggero]

LGTM 🎉

[guggero]

I think we should enforce UTC location in clock.NewTestClock (LND). Thoughts on this @guggero ?

Yes, that sounds good. Perhaps we can simply create a UTCClock implementation of the clock interface in Tapd and then replace Now() with Now().UTC().

[jharveyb]

We have some other writes that should probably be UTC?

taproot-assets/tapfreighter/parcel.go

Line 353 in 5373ccc

TransferTime: time.Now(),

Coin lease duration seems like local time rn instead of UTC also:

taproot-assets/tapfreighter/wallet.go

Line 236 in 5373ccc

expiry := time.Now().Add(defaultCoinLeaseDuration)

taproot-assets/tapfreighter/chain_porter.go

Line 974 in 5373ccc

time.Now().Add(defaultBroadcastCoinLeaseDuration),

IIUC we should query the DB in UTC as well:

taproot-assets/rpcserver.go

Line 3467 in 5373ccc

startTime = time.Now().AddDate(0, 0, -30)

taproot-assets/cmd/tapcli/addrs.go

Line 127 in 5373ccc

startTime := time.Now().Add(startOffset)

taproot-assets/tapdb/universe_federation.go

Line 118 in 5373ccc

LastSyncTime: time.Now(),

taproot-assets/tapgarden/custodian.go

Line 531 in 5373ccc

return c.cfg.AddrBook.SetAddrManaged(ctxt, addr, time.Now())

We also still have a bunch of non-UTC usage in tests and the test mock utilities.

In general I imagine we should store all times in UTC and only convert to local timezone for display, @guggero ?

[guggero]

@jharveyb I don't think we need to do anything outside of the tapdb package. Because for example in the RPC interface we use .Unix() which implicitly does UTC. This is specifically a database issue (the way sqlc and the DB driver format the time), not a general issue in my opinion.

So we should only make sure we use .UTC() before storing a timestamp in the DB.

[jharveyb]

Ah I see, the timezone we use elsewhere won't matter since the DB normalizes to UTC before write I guess?

I looked through the DB logic for other tables where we have timestamps and they look ok.

[jharveyb]

Good catch 👍🏽