tapfreighter+tapgarden: prevent fee overpayment #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
reviewed
Oct 9, 2023
| @@ -1397,6 +1399,12 @@ func (f *AssetWallet) AnchorVirtualTransactions(ctx context.Context, | |||
| return nil, fmt.Errorf("unable to extract psbt: %w", err) | |||
| } | |||
|
|
|||
| // Final TX sanity check. | |||
| err = blockchain.CheckTransactionSanity(btcutil.NewTx(finalTx)) | |||
|
|
||
| // The fee may exceed the total value of the change output, which means | ||
| // this spend is impossible with the given inputs and fee rate. | ||
| if changeValue-feeDelta < 0 { |
There was a problem hiding this comment.
I think we can just call CheckTransactionSanity again here? It should handle catching the negative output.
Even with that though, if we ended up in that case, even with a fee estimator that returned "nothing" (so defaults to 253 sat/kw), we have a bug here if we're arriving at negative outputs.
Roasbeef
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #538.
Adds sanity checks for signed TXs, before TX broadcast, to allow for more complete unwinding of a mint or send.