Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapdb: add unit test for universe leaf overflow #560

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

Roasbeef
Copy link
Member

In this commit, we add a test for the universe leaf overflow. This tests that if we try to register a leaf that'll overflow the tree, then we'll just return an error and bail out of the transaction.

Copy link
Collaborator

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - could be good to add a fetch after trying to cause the overflow to check that we can successfully fetch the same leaf / data stored before that point.

In this commit, we add a test for the universe leaf overflow. This tests
that if we try to register a leaf that'll overflow the tree, then we'll
just return an error and bail out of the transaction.
@Roasbeef Roasbeef merged commit 9649775 into main Oct 11, 2023
1 check passed
@guggero guggero deleted the universe-overflow-test branch October 11, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants