Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federation sync config #563

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Federation sync config #563

merged 4 commits into from
Oct 11, 2023

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Oct 11, 2023

This PR depends on #540 . Please merge #540 first. I've converted this PR to draft until all parent PRs have been merged.

These commits have already been approved here: #537

Please approve this PR @guggero @Roasbeef

This commit adds two tables for storing universe federation sync
configuration settings:
1. federation_global_sync_config stores global (but proof type specific)
federation sync configuration.
2. federation_uni_sync_config stores universe specific sync
configuration.
Add RPC endpoints for setting and querying for federation sync config:
* SetFederationSyncConfig
* QueryFederationSyncConfig
@ffranr ffranr marked this pull request as draft October 11, 2023 14:08
@ffranr ffranr self-assigned this Oct 11, 2023
@ffranr ffranr requested a review from jharveyb October 11, 2023 15:02
@Roasbeef Roasbeef marked this pull request as ready for review October 11, 2023 17:49
@Roasbeef Roasbeef changed the base branch from uni-namespace-proof-type to main October 11, 2023 17:49
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎎

@Roasbeef Roasbeef merged commit d65192b into main Oct 11, 2023
14 checks passed
@guggero guggero deleted the federation-sync-config-dep branch October 11, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants