tapcfg: fix defaults for testnet universe courier #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
force-pushed
the
fix-testnet-universe-courier
branch
from
ec75180
to
cba5754
Compare
When we made testnet the default, the default config logic wasn't updated to properly implement the fallback logic. As a result, on testnet, the mainnet courier was still being used.
Otherwise, we'll get a parsing error.
In this commit, we switch to `AllowSyncInsert=true` in the global config. This ensures that when syncing from scratch with the default config, the auto syncer will properly allow issuance proofs. Otherwise, it'll fall through and deny everything.
In this commit, we fix a bug in `QueryFederationSyncConfigs`. The query just returns nothing, not an error, so before we were using a blank config and trying to use that as the default.
We need to set this as the default otherwise, `universe roots` will return nothing for those with the default config. This'll return nothing as when we respond to queries, we filter out based on the config.
Roasbeef
force-pushed
the
fix-testnet-universe-courier
branch
from
8e9d273
to
851727a
Compare
|
Fixes work on testnet but hitting this issue for mainnet:
Was running an incorrect version, looks good! |
jharveyb
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we made testnet the default, the default config logic wasn't updated to properly implement the fallback logic. As a result, on testnet, the mainnet courier was still being used.