Manual fee rate support #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
reviewed
Oct 17, 2023
| log.Infof("sending with manual fee rate") | ||
|
|
||
| default: | ||
| feeRate, err = p.cfg.ChainBridge.EstimateFee( |
There was a problem hiding this comment.
Rather than conditionally call estimation here, we could instead lift it up to the rpcserver. So then we can drop the pointer to fee rate, as we compute that head of time.
Roasbeef
reviewed
Oct 18, 2023
In this commit, we add support for overriding the fee estimator and providing a target fee rate to the planter when finalizing a batch. Provided fee rates are only checked against a minimum value and not a maximum fee rate.
In this commit, we add support for overriding the fee estimator and providing a target fee rate to the freighter when performing a transfer. This only applies to sends to addresses and not via interactive vPSBTs.
Roasbeef
force-pushed
the
manual_fee_rate_support
branch
from
c009c5a
to
7bac238
Compare
Roasbeef
force-pushed
the
manual_fee_rate_support
branch
from
7bac238
to
96c8cc3
Compare
|
In line with our other software, this flag could be called |
|
Good point, will add that change in the upcoming fee PR. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #587
Fixes #538
Updates the planter and freighter to accept a fee rate in sat/kw, the same unit as the fee estimator, to use for the anchor transaction. The fee rate is checked against a minimum but not maximum, so users should be careful with fee units to avoid accidental overpayment.