scripts: use sed to work around sqlc LEFT JOIN issue #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
requested changes
Jul 15, 2022
In this commit, we modify the main script that we use to run the `sqlc` code generation to also replace the two fields that need to be `sql.NullInt32` for the LEFT JOIN compilation to work. Can be removed once this issue is fixed: sqlc-dev/sqlc#1334
Roasbeef
force-pushed
the
sqlc-workaround
branch
from
ad67554
to
11872d1
Compare
|
This should be g2g now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we modify the main script that we use to run the
sqlccode generation to also replace the two fields that need to be
sql.NullInt32for the LEFT JOIN compilation to work.Can be removed once this issue is fixed:
sqlc-dev/sqlc#1334