tarodb+tarogarden: construct+store proof files on disk for all minted assets #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
reviewed
Jul 28, 2022
|
A rebase would be useful as well here. |
Merged
Roasbeef
force-pushed
the
mint-with-asset-proof
branch
from
f1fe724
to
416b329
Compare
|
Rebased! |
jharveyb
reviewed
Aug 3, 2022
Roasbeef
force-pushed
the
mint-with-asset-proof
branch
from
416b329
to
2e538ea
Compare
|
Pushed up a fully rebased version. |
Roasbeef
force-pushed
the
mint-with-asset-proof
branch
from
2e538ea
to
4cbf4dc
Compare
guggero
reviewed
Aug 4, 2022
guggero
reviewed
Aug 4, 2022
This will be used later to construct SPV proofs for the flat file format.
In this commit, we add a new function that creates asset minting proofs. In particular, it assumes that all assets are created in the same transaction, and that transaction only has a change output and the minting output.
Allows us to enforce other variants elsewhere, in particular, we want all script keys to also be unique.
Similar to the prior commit, we'll use this later to use an UPSERT to update a proof file if one already exists when we go to insert.
…sets In this commit, we extend the pending asset storage to also store the complete set of proof files for all the assets created in the batch. This ensures that once an asset is seen as final, we can query the for the proof file.
With this commit, we ensure that once an asset is created, we retain a proof of the event on disk. This will be used later for transfers, and also challenge/reveal instances.
This ensures that we're always inserting the compressed encoded key into the database.
Roasbeef
force-pushed
the
mint-with-asset-proof
branch
from
4cbf4dc
to
e9a367b
Compare
|
Pushed up a commit to add that 33 byte constraint on all internal keys, and also display 33-byte keys on the RPC interface everywhere. |
guggero
approved these changes
Aug 5, 2022
|
Seems ready for merge |
dstadulis
pushed a commit
that referenced
this pull request
May 16, 2023
universe: add new federation envoy for managing federated universe sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we start to store a valid proof file for all minted assets on disk. Along the way we add a new (currently specific) routine for creating a minting file based on real data. For now we're just storing all the proof files directly in the database. In the future, I think we want to also have a replicator/archive the maintains the proof files both on disk and in the database. A third future source for replication would also be a base universe (for just the minting proofs) and also a universe/multi-verse, etc, etc.
In a follow up PR, we'll start to add verification+export RPC calls. These calls will be the future bridge for any variant of a send+receive flow.
Depends on #34