Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: export witness creation for keypath spends #79

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

jharveyb
Copy link
Collaborator

@jharveyb jharveyb commented Aug 8, 2022

Previously part of #67. Creating a valid witness for a keypath spend of a Taro asset was already implemented in the VM tests, but it needs to be exported to be used for spending to an address.

Not exporting the witness creation for scriptpath spends here because other changes are required before that is usable for spending to an address.

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌺

@Roasbeef Roasbeef merged commit d16ccd0 into main Aug 9, 2022
@guggero guggero deleted the vm-key-spend branch August 9, 2022 07:27
dstadulis pushed a commit that referenced this pull request May 16, 2023
itest: add test: receiver can receive after multi failed send attempts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants