Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taprpc: Set dec display when metadata is empty #979

Merged
merged 4 commits into from
Jun 27, 2024
Merged

Conversation

jharveyb
Copy link
Collaborator

Resolves #972 by setting the dec display as the only JSON object when the given metadata is empty. The RPC request that causes this behavior is tested in the meta itest, and I manually tested the CLI for:

  • Non-zero dec display, empty metadata, JSON meta type -> correct taprpc.AssetMeta struct is passed to the RPC, asset listed correctly after minting (this was with the exact CLI cmd Leo posted).
  • zero dec display, empty metadata, JSON meta type -> rejected for empty metadata
  • unknown meta type, empty metadata -> rejected for empty metadata (IIUC this was the existing behavior)

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cmd/tapcli/assets.go Show resolved Hide resolved
@Roasbeef Roasbeef merged commit fc97efa into main Jun 27, 2024
15 checks passed
@guggero guggero deleted the dec_display_empty_meta branch June 27, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[bug]: Minting a normal asset with --decimal_display does not yield expected results
2 participants